I love these shorts. However, I didn't realize that bright underwear really shows through. But then again, they are white so it makes sense. I ordered the medium and I'm 5'10" at about 180lbs with a 32" waist and 24" quads. They grip enough around the thighs without being uncomfortable. I might try the smalls next time because I do like my shorts tight and short.